Skip to content

PR546 with Upgrade script #608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 10 commits into from
Closed

PR546 with Upgrade script #608

wants to merge 10 commits into from

Conversation

KevinBKozan
Copy link
Contributor

Description

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@coveralls
Copy link

coveralls commented Feb 28, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.0006%) to 50.974% when pulling 1416667 on pr546WithUpgradeScript into f1820ff on develop.

soumyau
soumyau suggested changes Feb 28, 2020
View reviewed changes
Copy link
Contributor

@soumyau soumyau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation looks good. Had a question about why do we need an upgrade script in the first place. Wouldn't tests end up failing anyway without .url. There won't be any instances of such references unless it's a broken build or something, correct?

@KevinBKozan
Copy link
Contributor Author

@soumya-ashok MFTF actually (erroneously) will replace {{page}} with the url even if you don't manually specify .url}}, so any previous occurences would be getting taken care of by the framework.
As that changes, you then need to change the input to match the expectation

@soumyau
Copy link
Contributor

soumyau commented Feb 28, 2020 •
edited
Loading

@soumyau MFTF actually (erroneously) will replace {{page}} with the url even if you don't manually specify .url}}, so any previous occurences would be getting taken care of by the framework.
As that changes, you then need to change the input to match the expectation

@KevinBKozan Below is the current behavior (develop) without .url. MFTF doesn't resolve reference for AdminLoginPage. Test fails due to page not found, doesn't actually go to login page -

Entering Action Group [loginAsAdmin] LoginAsAdmin
I am on page "{{AdminLoginPage}}"
I fill field "#username","admin"
FAIL

@KevinBKozan
Copy link
Contributor Author

KevinBKozan commented Feb 28, 2020 •
edited
Loading

@soumyau I see, I was getting it mixed up, think I understand now.

Goal of this new feature is to fail early and specifically if they forget to specify .url}}. Outcome of tests is the same, so the upgrade script is pointless since presumably those tests would already be failing as well yeah?

In light of that we may be able to just kill this PR.

@KevinBKozan KevinBKozan closed this Mar 4, 2020
@KevinBKozan KevinBKozan deleted the pr546WithUpgradeScript branch April 30, 2020 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soumyau soumyau soumyau requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KevinBKozan @coveralls @soumyau @lbajsarowicz